Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Multi_Task_Adapters.ipynb by replacing canary2 with canary_custom #11636

Merged

Conversation

weiqingw4ng
Copy link
Collaborator

@weiqingw4ng weiqingw4ng commented Dec 17, 2024

What does this PR do ?

There is already a canary2.py file under the nemo/collections/common/prompts folder. In this tutorial, we register a new custom prompt formatter with the name canary2, which creates a conflict with the existing canary2.py. This PR resolves the conflict by changing the variable name from canary2 to canary_custom.

Collection: [Note which collection this PR will affect]
NeMo/tutorial/asr

Changelog

  • Add specific line by line info of high level changes in this PR.
    Updated requirements file

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994
Copy link
Collaborator

@weiqingw4ng lets merge this, but you have to cherry-pick / duplicate the PR to main. The current workflow is

  • send PRs to main
  • Add label 2.1.0 (or whatever is the latest) so that a CI action cherry picks the commit from main to the release branch.
  • Then merge both PRs.

@titu1994 titu1994 merged commit c278e5d into NVIDIA:r2.1.0 Dec 18, 2024
8 checks passed
@weiqingw4ng
Copy link
Collaborator Author

@weiqingw4ng lets merge this, but you have to cherry-pick / duplicate the PR to main. The current workflow is

  • send PRs to main
  • Add label 2.1.0 (or whatever is the latest) so that a CI action cherry picks the commit from main to the release branch.
  • Then merge both PRs.

@titu1994 Thank you so much for the tips! I have already submitted a new PR to main with label 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants