Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for initializing lhotse shar dataloader via field: list[path] mapping #11460

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented Dec 3, 2024

What does this PR do ?

Support for initializing lhotse shar dataloader via field: list[path] mapping

Collection: [Note which collection this PR will affect]

Changelog

  • Support for initializing lhotse shar dataloader via field: list[path] mapping

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the common label Dec 3, 2024
@pzelasko pzelasko marked this pull request as ready for review December 3, 2024 14:40
Signed-off-by: Piotr Żelasko <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.common.data.lhotse.cutset
nemo/collections/common/data/lhotse/cutset.py:541:0: C0301: Line too long (139/119) (line-too-long)
nemo/collections/common/data/lhotse/cutset.py:147:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:185:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:196:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:209:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:215:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:260:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:356:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/common/data/lhotse/cutset.py:404:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.61/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

[🤖]: Hi @pzelasko 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Copy link
Collaborator

@subhankar-ghosh subhankar-ghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anteju anteju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pzelasko pzelasko merged commit 97ee807 into main Dec 3, 2024
172 of 173 checks passed
@pzelasko pzelasko deleted the lhotse-shar-fields-init branch December 3, 2024 19:10
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
… mapping (NVIDIA#11460)

* Support for initializing lhotse shar dataloader via field: list[path] mapping

Signed-off-by: Piotr Żelasko <[email protected]>

* Unit test for lhotse shar fields init

Signed-off-by: Piotr Żelasko <[email protected]>

* Unit test for dynamically attaching a new field located in another dir

Signed-off-by: Piotr Żelasko <[email protected]>

* Update docs

Signed-off-by: Piotr Żelasko <[email protected]>

---------

Signed-off-by: Piotr Żelasko <[email protected]>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
… mapping (NVIDIA#11460)

* Support for initializing lhotse shar dataloader via field: list[path] mapping

Signed-off-by: Piotr Żelasko <[email protected]>

* Unit test for lhotse shar fields init

Signed-off-by: Piotr Żelasko <[email protected]>

* Unit test for dynamically attaching a new field located in another dir

Signed-off-by: Piotr Żelasko <[email protected]>

* Update docs

Signed-off-by: Piotr Żelasko <[email protected]>

---------

Signed-off-by: Piotr Żelasko <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants