-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for resiliency feature integration #11406
Conversation
[🤖]: Hi @maanug-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: Shriya Palsamudram <[email protected]>
6cd5a62
to
3e6d6c4
Compare
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
[🤖]: Hi @maanug-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: Shriya Palsamudram <[email protected]>
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified:
Thank you for improving NeMo's documentation! |
[🤖]: Hi @maanug-nv 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* init draft Signed-off-by: Shriya Palsamudram <[email protected]> * Fix FaultTolerencePlugin Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add StragglerDetection callback to all NeMo2.0 recipes Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add missing and remove unsued imports Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add ft launcher test Signed-off-by: Shriya Palsamudram <[email protected]> * fix typo Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix more typos Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * add ft launcher using nemo-run for llama3 test Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix serialization errors Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * create seperate ft test Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * change github actions test Signed-off-by: Shriya Palsamudram <[email protected]> * draft crash simulation Signed-off-by: Shriya Balaji Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Simulate a crash using step, disable checkpointing Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add a straggler detection test as well Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Revert enabling straggler_detection by default in all recipes Signed-off-by: Shriya Palsamudram <[email protected]> * Remove unused imports Signed-off-by: Shriya Palsamudram <[email protected]> * Remove extra check in ConfigValidationPlugin Signed-off-by: Shriya Palsamudram <[email protected]> * Address pylinter issues Signed-off-by: Shriya Palsamudram <[email protected]> * Improve straggler detection testing and add doc string Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix paths Signed-off-by: Shriya Palsamudram <[email protected]> * Add assert for crash Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Append run logs to a file after a crash Signed-off-by: Shriya Palsamudram <[email protected]> * Set FAULT_TOL_FINISHED_FLAG_FILE and FAULT_TOL_CFG_PATH Signed-off-by: Shriya Palsamudram <[email protected]> * fix imports Signed-off-by: Maanu Grover <[email protected]> --------- Signed-off-by: Shriya Palsamudram <[email protected]> Signed-off-by: ShriyaPalsamudram <[email protected]> Signed-off-by: Shriya Balaji Palsamudram <[email protected]> Signed-off-by: Shriya Rishab <[email protected]> Signed-off-by: Maanu Grover <[email protected]> Co-authored-by: Shriya Palsamudram <[email protected]> Co-authored-by: ShriyaPalsamudram <[email protected]> Co-authored-by: Shriya Rishab <[email protected]>
* init draft Signed-off-by: Shriya Palsamudram <[email protected]> * Fix FaultTolerencePlugin Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add StragglerDetection callback to all NeMo2.0 recipes Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add missing and remove unsued imports Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add ft launcher test Signed-off-by: Shriya Palsamudram <[email protected]> * fix typo Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix more typos Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * add ft launcher using nemo-run for llama3 test Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix serialization errors Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * create seperate ft test Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * change github actions test Signed-off-by: Shriya Palsamudram <[email protected]> * draft crash simulation Signed-off-by: Shriya Balaji Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Simulate a crash using step, disable checkpointing Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Add a straggler detection test as well Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Revert enabling straggler_detection by default in all recipes Signed-off-by: Shriya Palsamudram <[email protected]> * Remove unused imports Signed-off-by: Shriya Palsamudram <[email protected]> * Remove extra check in ConfigValidationPlugin Signed-off-by: Shriya Palsamudram <[email protected]> * Address pylinter issues Signed-off-by: Shriya Palsamudram <[email protected]> * Improve straggler detection testing and add doc string Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * fix paths Signed-off-by: Shriya Palsamudram <[email protected]> * Add assert for crash Signed-off-by: Shriya Palsamudram <[email protected]> * Apply isort and black reformatting Signed-off-by: ShriyaPalsamudram <[email protected]> * Append run logs to a file after a crash Signed-off-by: Shriya Palsamudram <[email protected]> * Set FAULT_TOL_FINISHED_FLAG_FILE and FAULT_TOL_CFG_PATH Signed-off-by: Shriya Palsamudram <[email protected]> * fix imports Signed-off-by: Maanu Grover <[email protected]> --------- Signed-off-by: Shriya Palsamudram <[email protected]> Signed-off-by: ShriyaPalsamudram <[email protected]> Signed-off-by: Shriya Balaji Palsamudram <[email protected]> Signed-off-by: Shriya Rishab <[email protected]> Signed-off-by: Maanu Grover <[email protected]> Co-authored-by: Shriya Palsamudram <[email protected]> Co-authored-by: ShriyaPalsamudram <[email protected]> Co-authored-by: Shriya Rishab <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
What does this PR do ?
Add back tests that were originally in #11117
Collection: [llm]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information