Sync vfm branch with main branch #11288

zpx01 · 2024-11-14T19:30:00Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

* inital version Signed-off-by: Nithin Rao Koluguri <nithinraok> * Support for RNNT, TDT, Hybrid Models Signed-off-by: Nithin Rao Koluguri <nithinraok> * move change of decoder stratery from mixin to individual model class Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * update transcribe_speech.py Signed-off-by: Nithin Rao Koluguri <nithinraok> * uncomment Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * add docs Signed-off-by: Nithin Rao Koluguri <nithinraok> * fix docs Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * codeql fixes Signed-off-by: Nithin Rao Koluguri <nithinraok> * unit tests Signed-off-by: Nithin Rao Koluguri <nithinraok> * minor rebase fix Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * add None case to restore the state set outside using decoding_stratergy() Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> * remove ipdb traces Signed-off-by: Nithin Rao Koluguri <nithinraok> * updates doc for transcription.py Signed-off-by: Nithin Rao Koluguri <nithinraok> * remove preserve alignment for AED models as it doesn;t support it Signed-off-by: Nithin Rao Koluguri <nithinraok> * lint warnings Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: Nithin Rao Koluguri <nithinraok> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao Koluguri <nithinraok> Co-authored-by: nithinraok <[email protected]>

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Handling tokenizer in PTQ for Nemo 2.0 Signed-off-by: Jan Lasek <[email protected]> * Print log msg and enable overriding Signed-off-by: Jan Lasek <[email protected]> * Warning for legacy tokenizer config Signed-off-by: Jan Lasek <[email protected]> * Save HF tokenizer to make tokenizer_config.yaml (almost) redundant Signed-off-by: Jan Lasek <[email protected]> * Handle tokenizer in a unified way Signed-off-by: Jan Lasek <[email protected]> * Move saving context within export Signed-off-by: Jan Lasek <[email protected]> * Fix typo in get_tokenzier Signed-off-by: Jan Lasek <[email protected]> * Reduce diff Signed-off-by: Jan Lasek <[email protected]> * Drop unused import Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]>

* fix datamodule resume Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * fix subclass Signed-off-by: Chen Cui <[email protected]> * docstrings and formats Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: cuichenx <[email protected]>

* ci: Move `bump mcore` to templates Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * final Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

Signed-off-by: Oliver Koenig <[email protected]>

Signed-off-by: Jan Lasek <[email protected]>

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…11045) * rename eval_beamsearch_ngram.py to eval_beamsearch_ngram_ctc.py in docs Signed-off-by: Elena Rastorgueva <[email protected]> * replace out of date installation instructions with pointer to NeMo README installation section Signed-off-by: Elena Rastorgueva <[email protected]> * point to user guide instead of readme Signed-off-by: Elena Rastorgueva <[email protected]> * some link updates Signed-off-by: Elena Rastorgueva <[email protected]> * update more links Signed-off-by: Elena Rastorgueva <[email protected]> --------- Signed-off-by: Elena Rastorgueva <[email protected]> Signed-off-by: Elena Rastorgueva <[email protected]>

Signed-off-by: Terry Kong <[email protected]>

Signed-off-by: Oliver Koenig <[email protected]>

…or Aligner (#10863) * fix(export): update API for disabling device reassignment in TRTLLM for Aligner [feat] Upgrade nemo-export path for aligner to TRTLLM-v12 and use python runtime Signed-off-by: Terry Kong <[email protected]> fix: forgot to always set _disable_torch_cuda_device_set Signed-off-by: Terry Kong <[email protected]> Signed-off-by: Terry Kong <[email protected]> Apply isort and black reformatting Signed-off-by: terrykong <[email protected]> invert torch device set Signed-off-by: Terry Kong <[email protected]> * remove comment Signed-off-by: Terry Kong <[email protected]> --------- Signed-off-by: Terry Kong <[email protected]>

Signed-off-by: Zeeshan Patel <[email protected]> Co-authored-by: Zeeshan Patel <[email protected]>

* Update pruning and distillation tutorial notebooks Signed-off-by: Gomathy Venkata Krishnan <[email protected]> * Update README Signed-off-by: Gomathy Venkata Krishnan <[email protected]> * Update batch size in width pruning script Signed-off-by: Gomathy Venkata Krishnan <[email protected]> * Update README Signed-off-by: Gomathy Venkata Krishnan <[email protected]> --------- Signed-off-by: Gomathy Venkata Krishnan <[email protected]>

* initial commit Signed-off-by: lilithgrigoryan <[email protected]> * add: default beam search implementation Signed-off-by: lilithgrigoryan <[email protected]> * fix: changed to removing duplicate hypothesis in separate function Signed-off-by: lilithgrigoryan <[email protected]> * fix: changed to cartesian product in choosing best hyp Signed-off-by: lilithgrigoryan <[email protected]> * fix: minor fixes in comments Signed-off-by: lilithgrigoryan <[email protected]> * add: maes decoding strategy Signed-off-by: lilithgrigoryan <[email protected]> * add: durations filtering in maes, lm fusion in progress Signed-off-by: lilithgrigoryan <[email protected]> * fix: refactored, added comments, command line args, finalized Signed-off-by: lilithgrigoryan <[email protected]> * fix: removed prints Signed-off-by: lilithgrigoryan <[email protected]> * add: docs Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix: minor fix Signed-off-by: lilithgrigoryan <[email protected]> * fix: rm beam_size=1 exception, rm duplicates check, fix error handling Signed-off-by: lilithgrigoryan <[email protected]> * fix: error handling Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix: removed evaluations file Signed-off-by: lilithgrigoryan <[email protected]> * rn: blank scoring Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * rm: blank scoring and duration beam size Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix: removed durations_beam_size from default beam search Signed-off-by: lilithgrigoryan <[email protected]> * add: logaddexp Signed-off-by: lilithgrigoryan <[email protected]> * rm: prefix search Signed-off-by: lilithgrigoryan <[email protected]> * rn: nested loop over extensions Signed-off-by: lilithgrigoryan <[email protected]> * fix: bug with caching Signed-off-by: lilithgrigoryan <[email protected]> * rm: topk on durations Signed-off-by: lilithgrigoryan <[email protected]> * add: restored prefix search Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * fix: fixed comments Signed-off-by: lilithgrigoryan <[email protected]> * refactored duplicate merging Signed-off-by: lilithgrigoryan <[email protected]> * changes batch scoring Signed-off-by: lilithgrigoryan <[email protected]> * refactored rnnt batch scoring Signed-off-by: lilithgrigoryan <[email protected]> * alsd first working Signed-off-by: lilithgrigoryan <[email protected]> * refactored Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * remove stacking operations Signed-off-by: lilithgrigoryan <[email protected]> * fixes im base class Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * remove potentially uninitialized local variable Signed-off-by: lilithgrigoryan <[email protected]> * default beam search minor fixes Signed-off-by: lilithgrigoryan <[email protected]> * add test, fix maes timesteps Signed-off-by: lilithgrigoryan <[email protected]> * rm file Signed-off-by: lilithgrigoryan <[email protected]> * rm file Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * clean up Signed-off-by: lilithgrigoryan <[email protected]> * fix comments Signed-off-by: lilithgrigoryan <[email protected]> * add ngram lm test Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix maes_num_steps=1 Signed-off-by: lilithgrigoryan <[email protected]> * fix kenlm model path Signed-off-by: lilithgrigoryan <[email protected]> * fix kenlm model full path Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * made requested changes Signed-off-by: lilithgrigoryan <[email protected]> * merge after isort Signed-off-by: lilithgrigoryan <[email protected]> * add prints to test Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * add Kenlm to asr requirements Signed-off-by: lilithgrigoryan <[email protected]> * remove prints in tests Signed-off-by: lilithgrigoryan <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add kenlm to test requirements Signed-off-by: lilithgrigoryan <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rm kenlm from link, add package-name Signed-off-by: lilithgrigoryan <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rm second kenlm installation Signed-off-by: lilithgrigoryan <[email protected]> * rm kenlm from dependencies make test optional Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix in test Signed-off-by: lilithgrigoryan <[email protected]> * fix in test Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix comments Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * add comments Signed-off-by: lilithgrigoryan <[email protected]> * add comments Signed-off-by: lilithgrigoryan <[email protected]> * splitted docstrings Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * add comments Signed-off-by: lilithgrigoryan <[email protected]> * splitted docstrings Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * add comments Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fixes to python3 type annotations Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * merging Signed-off-by: lilithgrigoryan <[email protected]> * merging Signed-off-by: lilithgrigoryan <[email protected]> * fix in return type Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * fix test Signed-off-by: lilithgrigoryan <[email protected]> * Apply isort and black reformatting Signed-off-by: lilithgrigoryan <[email protected]> * rm time_idx Signed-off-by: lilithgrigoryan <[email protected]> * fix comments to python3 style Signed-off-by: lilithgrigoryan <[email protected]> --------- Signed-off-by: lilithgrigoryan <[email protected]> Signed-off-by: lilithgrigoryan <[email protected]> Co-authored-by: lilithgrigoryan <[email protected]> Co-authored-by: lilithgrigoryan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* update nemo1->2 conversion according to changes in main Signed-off-by: Huiying Li <[email protected]> * Apply isort and black reformatting Signed-off-by: HuiyingLi <[email protected]> * format fix Signed-off-by: Huiying Li <[email protected]> * add docstrings Signed-off-by: Huiying Li <[email protected]> --------- Signed-off-by: Huiying Li <[email protected]> Signed-off-by: HuiyingLi <[email protected]> Co-authored-by: HuiyingLi <[email protected]>

* add llama 3.1 recipes Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * fix pylint Signed-off-by: Chen Cui <[email protected]> * Fix llama3.1 wrong config in io.json --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: cuichenx <[email protected]> Co-authored-by: Ao Tang <[email protected]>

* Fix Starcoder_15 SFT recipe * Fix PP type SFT recipe * Fix PP type SFT recipe * Fix Gemma2b SFT TP=1 * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * Fix more sft recipe * remove pp dtype * remove pp dtype

* Configure no restart validation loop in nl.Trainer Signed-off-by: Hemil Desai <[email protected]> * fix Signed-off-by: Hemil Desai <[email protected]> * Skip validation whenever restarting=True Signed-off-by: Hemil Desai <[email protected]> * PR feedback Signed-off-by: Hemil Desai <[email protected]> * Apply isort and black reformatting Signed-off-by: hemildesai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: hemildesai <[email protected]>

…lable (#11199) Signed-off-by: Hemil Desai <[email protected]>

Signed-off-by: Maanu Grover <[email protected]>

* Use MegatronDataSampler in HfDataset Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Co-authored-by: akoumpa <[email protected]>

Signed-off-by: Dong Hyuk Chang <[email protected]>

nemo/collections/diffusion/data/diffusion_fake_datamodule.py

+
+        video_latent = torch.ones(self.seq_length, c * p**2, dtype=torch.bfloat16) * 0.5
+        text_embedding = torch.randn(self.text_seqlen, self.text_dim, dtype=torch.bfloat16)
+        pos_emb = pos_id_3d.get_pos_id_3d(t=t, h=h // p, w=w // p).reshape(-1, 3)


nemo/collections/diffusion/train.py

+        torch.cuda.memory._record_memory_history(
+            True,
+            # Keep 100,000 alloc/free events from before the snapshot
+            trace_alloc_max_entries=100000,
+            # Record stack information for the trace events
+            trace_alloc_record_context=True,
+        )


nithinraok and others added 24 commits November 10, 2024 15:01

[🤠]: Howdy folks, let's bump Dockerfile.ci to 1b8fce7 ! (#11247)

5c5b023

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[🤠]: Howdy folks, let's bump Dockerfile.ci to 47ff44e ! (#11254)

66766b1

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: Update baseline (#11205)

77c8e91

Signed-off-by: Oliver Koenig <[email protected]>

Remove deprecated builder_opt param from build command (#11259)

b26c220

Signed-off-by: Jan Lasek <[email protected]>

chore(beep boop 🤖): Bump MCORE_TAG=aded519... (2024-11-12) (#11260)

098aa18

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(export): GPT models w/ bias=False convert properly (#11255)

2d4f495

Signed-off-by: Terry Kong <[email protected]>

ci: Run secrets detector on pull_request_target (#11263)

24e2871

Signed-off-by: Oliver Koenig <[email protected]>

new vfm training features (#11246)

6e8e974

Signed-off-by: Zeeshan Patel <[email protected]> Co-authored-by: Zeeshan Patel <[email protected]>

Handle _io_unflatten_object when _thread_local.output_dir is not avai…

af91d28

…lable (#11199) Signed-off-by: Hemil Desai <[email protected]>

change default ckpt name (#11277)

8b0c311

Signed-off-by: Maanu Grover <[email protected]>

Remove opencc upperbound (#10909)

0625327

Signed-off-by: Dong Hyuk Chang <[email protected]>

zpx01 requested review from pablo-garay and ko3n1g as code owners November 14, 2024 19:30

github-advanced-security bot found potential problems Nov 14, 2024

View reviewed changes

github-actions bot added TTS ASR NLP labels Nov 14, 2024

ko3n1g temporarily deployed to main November 15, 2024 11:20 — with GitHub Actions Inactive

ko3n1g temporarily deployed to main November 15, 2024 11:32 — with GitHub Actions Inactive

ko3n1g had a problem deploying to main November 15, 2024 11:32 — with GitHub Actions Failure

ko3n1g temporarily deployed to main November 15, 2024 11:32 — with GitHub Actions Inactive

ko3n1g temporarily deployed to main November 15, 2024 11:47 — with GitHub Actions Inactive

ko3n1g had a problem deploying to main November 15, 2024 11:47 — with GitHub Actions Failure

ko3n1g temporarily deployed to main November 15, 2024 11:47 — with GitHub Actions Inactive

ko3n1g temporarily deployed to main November 15, 2024 12:05 — with GitHub Actions Inactive

ko3n1g temporarily deployed to main November 15, 2024 12:06 — with GitHub Actions Inactive

ko3n1g had a problem deploying to main November 15, 2024 12:06 — with GitHub Actions Failure

ko3n1g temporarily deployed to main November 15, 2024 12:06 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync vfm branch with main branch #11288

Sync vfm branch with main branch #11288

zpx01 commented Nov 14, 2024

Sync vfm branch with main branch #11288

Sync vfm branch with main branch #11288

Conversation

zpx01 commented Nov 14, 2024

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information