Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nemotron Recipe #11118

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Nemotron Recipe #11118

merged 10 commits into from
Nov 4, 2024

Conversation

suiyoubi
Copy link
Collaborator

@suiyoubi suiyoubi commented Oct 31, 2024

What does this PR do ?

Rename Nemotron4-22b to Nemotron3-22b.
Added Finetune Recipes for all nemotron models.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@suiyoubi suiyoubi changed the title Draft: Nemotron Recipe Nemotron Recipe Oct 31, 2024
@suiyoubi suiyoubi requested a review from ahmadki October 31, 2024 15:54
cuichenx
cuichenx previously approved these changes Nov 1, 2024
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ahmadki
ahmadki previously approved these changes Nov 1, 2024
Copy link
Collaborator

@ahmadki ahmadki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@suiyoubi suiyoubi dismissed stale reviews from ahmadki and cuichenx via 4fe6e93 November 1, 2024 15:49
@suiyoubi suiyoubi enabled auto-merge (squash) November 1, 2024 15:50
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Nov 1, 2024
Signed-off-by: Chen Cui <[email protected]>
cuichenx
cuichenx previously approved these changes Nov 1, 2024
@cuichenx cuichenx added Run CICD and removed Run CICD labels Nov 1, 2024
ahmadki
ahmadki previously approved these changes Nov 1, 2024
@suiyoubi suiyoubi dismissed stale reviews from ahmadki and cuichenx via a0d4f8e November 1, 2024 16:34
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Nov 1, 2024
cuichenx
cuichenx previously approved these changes Nov 1, 2024
ahmadki
ahmadki previously approved these changes Nov 1, 2024
@suiyoubi suiyoubi dismissed stale reviews from ahmadki and cuichenx via fb5b19a November 1, 2024 17:17
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@suiyoubi suiyoubi merged commit a5c8413 into main Nov 4, 2024
162 of 163 checks passed
@suiyoubi suiyoubi deleted the aot/nemotron-finetune branch November 4, 2024 01:17
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* add finetune recipe for nemotron

* Refactor Nemotron4-22b to Nemotron3-22b,

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* optimize 22b finetune recipe

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* add finetune recipe for nemotron

* Refactor Nemotron4-22b to Nemotron3-22b,

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* optimize 22b finetune recipe

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* add finetune recipe for nemotron

* Refactor Nemotron4-22b to Nemotron3-22b,

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* optimize 22b finetune recipe

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
yashaswikarnati pushed a commit that referenced this pull request Nov 21, 2024
* add finetune recipe for nemotron

* Refactor Nemotron4-22b to Nemotron3-22b,

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* optimize 22b finetune recipe

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* add finetune recipe for nemotron

* Refactor Nemotron4-22b to Nemotron3-22b,

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* optimize 22b finetune recipe

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants