Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MCoreGPTModel import in llm.gpt.model.base #11109

Merged
merged 1 commit into from
Oct 31, 2024
+1 −3
Merged

Fix MCoreGPTModel import in llm.gpt.model.base #11109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions nemo/collections/llm/gpt/model/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import torch.distributed
from megatron.core.inference.model_inference_wrappers.gpt.gpt_inference_wrapper import GPTInferenceWrapper
from megatron.core.inference.model_inference_wrappers.inference_wrapper_config import InferenceWrapperConfig
from megatron.core.models.gpt.gpt_model import GPTModel as MCoreGPTModel
from megatron.core.optimizer import OptimizerConfig
from megatron.core.transformer.spec_utils import ModuleSpec
from megatron.core.transformer.transformer_config import TransformerConfig
Expand All @@ -44,8 +45,6 @@
_grad_accum_fusion_available = False

if TYPE_CHECKING:
from megatron.core.models.gpt.gpt_model import GPTModel as MCoreGPTModel

from nemo.collections.common.tokenizers.tokenizer_spec import TokenizerSpec


Expand Down Expand Up @@ -189,7 +188,6 @@ def configure_model(self, tokenizer) -> "MCoreGPTModel":
) % vp_size == 0, "Make sure the number of model chunks is the same across all pipeline stages."

from megatron.core import parallel_state
from megatron.core.models.gpt.gpt_model import GPTModel as MCoreGPTModel

transformer_layer_spec = self.transformer_layer_spec
if not isinstance(transformer_layer_spec, ModuleSpec):
Expand Down
Loading