Fix yaml serialization in io mixin #11106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hemil Desai <[email protected]>
cuichenx
reviewed
Oct 30, 2024
nemo/lightning/io/mixin.py
Outdated
| call = False | ||
| except Exception: |
There was a problem hiding this comment.
is it possible to specify the exception types here? or is it difficult to enumerate
There was a problem hiding this comment.
I can change it to AttributeError
There was a problem hiding this comment.
Changed in bd903a0
Signed-off-by: Hemil Desai <[email protected]>
Updated in bd903a0 |
oyilmaz-nvidia
approved these changes
Oct 31, 2024
|
[🤖]: Hi @hemildesai 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
|
There was a further commit after the triggered CI run but it was a docstring name + name change which shouldnt affect result: |
ko3n1g
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Fix yaml serialization in io mixin Signed-off-by: Hemil Desai <[email protected]> * Add docstring Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Fix yaml serialization in io mixin * Add docstring --------- Signed-off-by: Hemil Desai <[email protected]> Co-authored-by: Hemil Desai <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Fix yaml serialization in io mixin Signed-off-by: Hemil Desai <[email protected]> * Add docstring Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
lilyw97
pushed a commit
to lilyw97/NeMo
that referenced
this pull request
Nov 13, 2024
* Fix yaml serialization in io mixin Signed-off-by: Hemil Desai <[email protected]> * Add docstring Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]>
HuiyingLi
pushed a commit
to HuiyingLi/NeMo
that referenced
this pull request
Nov 15, 2024
* Fix yaml serialization in io mixin Signed-off-by: Hemil Desai <[email protected]> * Add docstring Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Fix yaml serialization in io mixin Signed-off-by: Hemil Desai <[email protected]> * Add docstring Signed-off-by: Hemil Desai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses class only when data.qualname or similar fails