Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use code-freeze via Nemo-FW-Templates #11073

Merged
merged 7 commits into from
Oct 29, 2024
Merged

ci: Use code-freeze via Nemo-FW-Templates #11073

merged 7 commits into from
Oct 29, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 29, 2024

What does this PR do ?

Here's the definition of the called workflow: NVIDIA/NeMo-FW-CI-templates#2

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <[email protected]>
@github-actions github-actions bot added the CI label Oct 29, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g changed the title ci: Use FW-templates ci: Use code-freeze via Nemo-FW-Templates Oct 29, 2024
@ko3n1g ko3n1g marked this pull request as ready for review October 29, 2024 09:41
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner October 29, 2024 09:41
@ko3n1g ko3n1g merged commit 0512cea into main Oct 29, 2024
13 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/code-freeze branch October 29, 2024 21:34
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* ci: Use FW-templates

Signed-off-by: Oliver Koenig <[email protected]>

* rename

Signed-off-by: Oliver Koenig <[email protected]>

* test

Signed-off-by: Oliver Koenig <[email protected]>

* use slack_endpoint

Signed-off-by: Oliver Koenig <[email protected]>

* will this work?

Signed-off-by: Oliver Koenig <[email protected]>

* SLACK_RELEASE_ENDPOINT

Signed-off-by: Oliver Koenig <[email protected]>

* secret

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* ci: Use FW-templates

Signed-off-by: Oliver Koenig <[email protected]>

* rename

Signed-off-by: Oliver Koenig <[email protected]>

* test

Signed-off-by: Oliver Koenig <[email protected]>

* use slack_endpoint

Signed-off-by: Oliver Koenig <[email protected]>

* will this work?

Signed-off-by: Oliver Koenig <[email protected]>

* SLACK_RELEASE_ENDPOINT

Signed-off-by: Oliver Koenig <[email protected]>

* secret

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* ci: Use FW-templates

Signed-off-by: Oliver Koenig <[email protected]>

* rename

Signed-off-by: Oliver Koenig <[email protected]>

* test

Signed-off-by: Oliver Koenig <[email protected]>

* use slack_endpoint

Signed-off-by: Oliver Koenig <[email protected]>

* will this work?

Signed-off-by: Oliver Koenig <[email protected]>

* SLACK_RELEASE_ENDPOINT

Signed-off-by: Oliver Koenig <[email protected]>

* secret

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* ci: Use FW-templates

Signed-off-by: Oliver Koenig <[email protected]>

* rename

Signed-off-by: Oliver Koenig <[email protected]>

* test

Signed-off-by: Oliver Koenig <[email protected]>

* use slack_endpoint

Signed-off-by: Oliver Koenig <[email protected]>

* will this work?

Signed-off-by: Oliver Koenig <[email protected]>

* SLACK_RELEASE_ENDPOINT

Signed-off-by: Oliver Koenig <[email protected]>

* secret

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants