Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Re-add secrets detector #11038

Merged
merged 1 commit into from
Oct 29, 2024
Merged

ci: Re-add secrets detector #11038

merged 1 commit into from
Oct 29, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 25, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Oct 25, 2024
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/secrets-detector branch from d8a4c2c to 4ef842b Compare October 25, 2024 13:46
@ko3n1g ko3n1g marked this pull request as ready for review October 25, 2024 13:47
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner October 25, 2024 13:47
@ko3n1g ko3n1g merged commit 3209aea into main Oct 29, 2024
13 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/secrets-detector branch October 29, 2024 07:16
akoumpa pushed a commit that referenced this pull request Oct 29, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants