Fix export of configuration parameters to Weights and Biases #10995
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soluwalana
force-pushed
the
solu/llm-5007
branch
from
a81f622 to
26fa93a
Compare
Add test to ensure json serializability of hparams_init after restore Signed-off-by: Sam Oluwalana <[email protected]>
soluwalana
force-pushed
the
solu/llm-5007
branch
from
26fa93a to
c8438f9
Compare
titu1994
previously approved these changes
Oct 29, 2024
|
@ericharper @titu1994 can you trigger the Nemo_CICD_Test, cicd-test-container-setup, and gpu-test actions? |
auto-merge was automatically disabled
November 5, 2024 04:50
Head branch was pushed to by a user without write access
Signed-off-by: Sam Oluwalana <[email protected]>
soluwalana
force-pushed
the
solu/llm-5007
branch
from
f8856fa to
46e5343
Compare
Signed-off-by: soluwalana <[email protected]>
lilyw97
pushed a commit
to lilyw97/NeMo
that referenced
this pull request
Nov 13, 2024
…10995) * Fix export of configuration parameters to weights and biases Add test to ensure json serializability of hparams_init after restore Signed-off-by: Sam Oluwalana <[email protected]> * Function was moved in recent versions Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> --------- Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Co-authored-by: soluwalana <[email protected]>
HuiyingLi
pushed a commit
to HuiyingLi/NeMo
that referenced
this pull request
Nov 15, 2024
…10995) * Fix export of configuration parameters to weights and biases Add test to ensure json serializability of hparams_init after restore Signed-off-by: Sam Oluwalana <[email protected]> * Function was moved in recent versions Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> --------- Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Co-authored-by: soluwalana <[email protected]>
yashaswikarnati
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Fix export of configuration parameters to weights and biases Add test to ensure json serializability of hparams_init after restore Signed-off-by: Sam Oluwalana <[email protected]> * Function was moved in recent versions Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> --------- Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Co-authored-by: soluwalana <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
…10995) * Fix export of configuration parameters to weights and biases Add test to ensure json serializability of hparams_init after restore Signed-off-by: Sam Oluwalana <[email protected]> * Function was moved in recent versions Signed-off-by: Sam Oluwalana <[email protected]> * Apply isort and black reformatting Signed-off-by: soluwalana <[email protected]> --------- Signed-off-by: Sam Oluwalana <[email protected]> Signed-off-by: soluwalana <[email protected]> Co-authored-by: soluwalana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR corrects an error in ModelPT.py that only partially converts the _hparams_initial from an OmegaConf object to a dictionary before exporting to the various loggers.
This was particularly an issue with search functionality based on metadata in Weights and Biases due to the cfg object being a string representation of the OmegaConf object.
Collection: Core
Changelog
Reference Images
Prior to fix
cfg is recorded as a str(OmegaConf.DictConfig) in Weights and Biases
After fix
cfg is correctly searchable in Weights and Biases
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information