[fix] Ensures disabling exp_manager with exp_manager=null does not error #10651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
For context, exp_manager is supported by exp_manager: https://github.com/NVIDIA/NeMo/blob/5bd2b899964057efb2ab72fd040b5b386c5b557d/nemo/utils/exp_manager.py#L387-L389 Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: terrykong <[email protected]> Signed-off-by: Terry Kong <[email protected]>
terrykong
force-pushed
the
tk/v12/exp-manager-can-be-none
branch
from
9b4604c
to
025e094
Compare
|
[🤖]: Hi @terrykong 👋, I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨ So it might be time to merge this PR or like to get some approvals 🚀 But I'm just a 🤖 so I'll leave it you what to do next. Have a great day! //cc @ko3n1g |
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ror (#10651) * [fix] Ensures disabling exp_manager with exp_manager=null does not error For context, exp_manager is supported by exp_manager: https://github.com/NVIDIA/NeMo/blob/5bd2b899964057efb2ab72fd040b5b386c5b557d/nemo/utils/exp_manager.py#L387-L389 Signed-off-by: Terry Kong <[email protected]> * Apply isort and black reformatting Signed-off-by: terrykong <[email protected]> Signed-off-by: Terry Kong <[email protected]> --------- Signed-off-by: Terry Kong <[email protected]> Signed-off-by: terrykong <[email protected]> Co-authored-by: terrykong <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
…ror (NVIDIA#10651) * [fix] Ensures disabling exp_manager with exp_manager=null does not error For context, exp_manager is supported by exp_manager: https://github.com/NVIDIA/NeMo/blob/5bd2b899964057efb2ab72fd040b5b386c5b557d/nemo/utils/exp_manager.py#L387-L389 Signed-off-by: Terry Kong <[email protected]> * Apply isort and black reformatting Signed-off-by: terrykong <[email protected]> Signed-off-by: Terry Kong <[email protected]> --------- Signed-off-by: Terry Kong <[email protected]> Signed-off-by: terrykong <[email protected]> Co-authored-by: terrykong <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, None is supposed to be supported by exp_manager:
NeMo/nemo/utils/exp_manager.py
Lines 387 to 389 in 5bd2b89
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information