MCORE interface for TP-only FP8 AMAX reduction #10437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangkug Lym <[email protected]>
|
Talked with @erhoo82 offline 8307fcda5fff57ab0e77131b09bf37da997ec1f2 is sufficient for this PR. |
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
approved these changes
Sep 11, 2024
pablo-garay
approved these changes
Sep 11, 2024
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: adityavavre <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: Alexandros Koumparoulis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Performance FP8 AMAX reduction in TP (+CP) domain only compared to the default domain of TP+DP (+CP).
TP-only FP8 reduction would only work with training from scratch at the moment.
Changelog
model.tp_only_amax_redto TransformerConfig interfaceUsage
model.tp_only_amax_red=Trueto reduce FP8 AMAX only in TP (+CP) domainGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information