Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Token permission to cancel Workflow run #10095

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Aug 9, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Aug 9, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Aug 9, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/token-permission branch from 1ff428f to d5a4cac Compare August 12, 2024 12:42
@ko3n1g ko3n1g removed the Run CICD label Aug 12, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/token-permission branch from d5a4cac to eb62da3 Compare August 12, 2024 13:04
@ko3n1g ko3n1g marked this pull request as ready for review August 12, 2024 13:04
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner August 12, 2024 13:04
@ko3n1g ko3n1g merged commit 4b4f763 into main Aug 12, 2024
10 of 11 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/token-permission branch August 12, 2024 13:04
pablo-garay added a commit that referenced this pull request Aug 13, 2024
pablo-garay added a commit that referenced this pull request Aug 13, 2024
* Revert "ci: Proper cleanup (#10114)"

This reverts commit d6cfdc0.

* Revert "ci: Token permission to cancel Workflow run (#10095)"

This reverts commit 4b4f763.

* Stable difussion optional

* Make CPU unit tests optional (failing recently) until refactor
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
* ci: Token permission to cancel Workflow run

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Use template

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Combine cleanup and main job

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: adityavavre <[email protected]>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
* Revert "ci: Proper cleanup (NVIDIA#10114)"

This reverts commit d6cfdc0.

* Revert "ci: Token permission to cancel Workflow run (NVIDIA#10095)"

This reverts commit 4b4f763.

* Stable difussion optional

* Make CPU unit tests optional (failing recently) until refactor

Signed-off-by: adityavavre <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* ci: Token permission to cancel Workflow run

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Use template

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Combine cleanup and main job

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Revert "ci: Proper cleanup (#10114)"

This reverts commit d6cfdc0.

* Revert "ci: Token permission to cancel Workflow run (#10095)"

This reverts commit 4b4f763.

* Stable difussion optional

* Make CPU unit tests optional (failing recently) until refactor
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* ci: Token permission to cancel Workflow run

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Use template

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Combine cleanup and main job

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Revert "ci: Proper cleanup (NVIDIA#10114)"

This reverts commit d6cfdc0.

* Revert "ci: Token permission to cancel Workflow run (NVIDIA#10095)"

This reverts commit 4b4f763.

* Stable difussion optional

* Make CPU unit tests optional (failing recently) until refactor

Signed-off-by: Hainan Xu <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* ci: Token permission to cancel Workflow run

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Use template

Signed-off-by: Oliver Koenig <[email protected]>

* ci: Combine cleanup and main job

Signed-off-by: Oliver Koenig <[email protected]>

---------

Signed-off-by: Oliver Koenig <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Revert "ci: Proper cleanup (NVIDIA#10114)"

This reverts commit d6cfdc0.

* Revert "ci: Token permission to cancel Workflow run (NVIDIA#10095)"

This reverts commit 4b4f763.

* Stable difussion optional

* Make CPU unit tests optional (failing recently) until refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant