Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nemotron Conversion script #10031

Merged
merged 22 commits into from
Aug 6, 2024
Merged

Nemotron Conversion script #10031

merged 22 commits into from
Aug 6, 2024

Conversation

suiyoubi
Copy link
Collaborator

@suiyoubi suiyoubi commented Aug 2, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@suiyoubi suiyoubi requested a review from cuichenx August 2, 2024 19:48
cuichenx
cuichenx previously approved these changes Aug 2, 2024
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suiyoubi suiyoubi requested a review from cuichenx August 3, 2024 13:07
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Aug 3, 2024
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Aug 6, 2024
@suiyoubi suiyoubi merged commit d4d41ed into main Aug 6, 2024
225 checks passed
@suiyoubi suiyoubi deleted the aot/nemotron branch August 6, 2024 17:15
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
* Add nemotron conversion script

* add support for converting to the full hf repo

* fix typo

* fix cpu mode

* typo fix

* add support for GPT2 tokenizer

* remove pretraining_tp arg

* remove normalization

* use llamatokenizer for sentencepiece

* add kv_channels and gated_mlp

* -1 for kv_channel dim

* remove gated proj in conversion script

* use pretrainedtokenizerfast

* code cleanup

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* PR comments resolved

* update tokenizer logic

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
Signed-off-by: adityavavre <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Add nemotron conversion script

* add support for converting to the full hf repo

* fix typo

* fix cpu mode

* typo fix

* add support for GPT2 tokenizer

* remove pretraining_tp arg

* remove normalization

* use llamatokenizer for sentencepiece

* add kv_channels and gated_mlp

* -1 for kv_channel dim

* remove gated proj in conversion script

* use pretrainedtokenizerfast

* code cleanup

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* PR comments resolved

* update tokenizer logic

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Add nemotron conversion script

* add support for converting to the full hf repo

* fix typo

* fix cpu mode

* typo fix

* add support for GPT2 tokenizer

* remove pretraining_tp arg

* remove normalization

* use llamatokenizer for sentencepiece

* add kv_channels and gated_mlp

* -1 for kv_channel dim

* remove gated proj in conversion script

* use pretrainedtokenizerfast

* code cleanup

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* PR comments resolved

* update tokenizer logic

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Add nemotron conversion script

* add support for converting to the full hf repo

* fix typo

* fix cpu mode

* typo fix

* add support for GPT2 tokenizer

* remove pretraining_tp arg

* remove normalization

* use llamatokenizer for sentencepiece

* add kv_channels and gated_mlp

* -1 for kv_channel dim

* remove gated proj in conversion script

* use pretrainedtokenizerfast

* code cleanup

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

* PR comments resolved

* update tokenizer logic

* Apply isort and black reformatting

Signed-off-by: suiyoubi <[email protected]>

---------

Signed-off-by: suiyoubi <[email protected]>
Co-authored-by: suiyoubi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants