Cleanups related to removing factory from BERT init calls

Signed-off-by: Tomasz Kornuta <[email protected]>
NVIDIA · Feb 4, 2020 · 720f5c5 · 720f5c5
1 parent e59fcdb
commit 720f5c5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/examples/asr/notebooks/2_Online_ASR_Microphone_Demo.ipynb b/examples/asr/notebooks/2_Online_ASR_Microphone_Demo.ipynb
@@ -173,7 +173,6 @@
     "data_layer = AudioDataLayer()\n",
     "\n",
     "data_preprocessor = nemo_asr.AudioToMelSpectrogramPreprocessor(\n",
-    "    factory=neural_factory,\n",
     "    **model_definition['AudioToMelSpectrogramPreprocessor'])\n",
     "\n",
     "jasper_encoder = nemo_asr.JasperEncoder(\n",

diff --git a/examples/nlp/joint_intent_slot_with_bert.py b/examples/nlp/joint_intent_slot_with_bert.py
@@ -88,12 +88,12 @@
 """
 if args.bert_checkpoint and args.bert_config:
     pretrained_bert_model = nemo.collections.nlp.nm.trainables.common.huggingface.BERT(
-        config_filename=args.bert_config, factory=nf
+        config_filename=args.bert_config
     )
     pretrained_bert_model.restore_from(args.bert_checkpoint)
 else:
     pretrained_bert_model = nemo.collections.nlp.nm.trainables.common.huggingface.BERT(
-        pretrained_model_name=args.pretrained_bert_model, factory=nf
+        pretrained_model_name=args.pretrained_bert_model
     )
 
 hidden_size = pretrained_bert_model.hidden_size

diff --git a/examples/tts/tacotron2.py b/examples/tts/tacotron2.py
@@ -164,7 +164,7 @@ def create_train_dag(
 
     # Callbacks needed to print info to console and Tensorboard
     train_callback = nemo.core.SimpleLossLoggerCallback(
-        tensors=[loss_t, spec_target, mel_postnet, gate, gate_target, alignments,],
+        tensors=[loss_t, spec_target, mel_postnet, gate, gate_target, alignments],
         print_func=lambda x: nemo.logging.info(f"Loss: {x[0].data}"),
         log_to_tb_func=partial(tacotron2_log_to_tb_func, log_images=True, log_images_freq=log_freq),
         tb_writer=neural_factory.tb_writer,