remove duplicate 340b params #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Malay Nagda <[email protected]>
erhoo82
reviewed
Jan 7, 2025
| @@ -135,7 +135,6 @@ model: | |||
| defer_embedding_wgrad_compute: True | |||
| wgrad_deferral_limit: 22 | |||
| cross_entropy_loss_fusion: True | |||
| enable_vboost: True | |||
There was a problem hiding this comment.
Where is enable_vboost defined if this is removed?
There was a problem hiding this comment.
defined in launcher_scripts/conf/config.yaml...
the one defined above is under model key which is redundant as vboost is used outside the scope of model
There was a problem hiding this comment.
the main issue was with duplicated ub_tp_comm_overlap key which caused jobs to crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.