Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-v3 CI changes into dev #97

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Merge release-v3 CI changes into dev #97

merged 2 commits into from
Jun 6, 2024

Conversation

bdice
Copy link
Collaborator

@bdice bdice commented Jun 6, 2024

This merges some CI changes from release-v3 into dev.

@bdice bdice merged commit 733fb41 into dev Jun 6, 2024
6 checks passed
Copy link

@invisiblepancake invisiblepancake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Checkout Action:

Updated from actions/checkout@v2 to actions/checkout@v3.
Python Setup:

Added steps to set up Python only for x86_64 architecture using actions/setup-python@v4.
Added a step to build the source distribution (sdist) only for x86_64.
QEMU Setup:

No changes to the QEMU setup step.
Build Wheels:

Updated from pypa/[email protected] to pypa/[email protected].
Modified the CIBW_SKIP and CIBW_BUILD environment variables to skip cp36-* and cp37-* and to build all CPython versions (cp*).
Docker Smoke Tests:

Added Python 3.11 to the list of versions for smoke testing.
Upload Artifact:

Updated from actions/upload-artifact@v2 to actions/upload-artifact@v3.
Evaluation
Updates to Actions:

The updates to use the latest versions of actions (checkout, setup-python, upload-artifact) are appropriate and align with best practices to ensure compatibility and security.
Conditional Steps:

Adding conditional steps to set up Python and build the source distribution only for x86_64 architecture is efficient and reduces unnecessary steps for other architectures.
Build and Test Configurations:

Updating cibuildwheel version and modifying CIBW_SKIP and CIBW_BUILD variables to include all CPython versions and exclude older versions (cp36-, cp37-) is a good approach to maintain up-to-date builds and focus on supported versions.
Including Python 3.11 in smoke tests ensures broader compatibility testing.
Recommendations
Testing: Ensure that the workflow runs successfully with the new configurations and that all tests pass.
Documentation: Update any relevant documentation to reflect these changes, especially if there are new requirements or dependencies.
Further Review: If there are any additional changes or feedback from reviewers, address them accordingly.
The changes look well-structured and align with best practices. If verified and tested, you can proceed with merging these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants