Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matvec output dims to match A rather than B #523

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

tbensonatl
Copy link
Collaborator

For matvecs, the batch dimensions for A and B should match and the final output dimension should match dim Rank-1 from A. Also generalize batching support so that the size of out_dims_ is based on the output rank.

For matvecs, the batch dimensions for A and B should match
and the final output dimension should match dim Rank-1 from A.
Also generalize batching support so that the size of out_dims_
is based on the output rank.
@tbensonatl
Copy link
Collaborator Author

/blossom-ci

@tbensonatl tbensonatl merged commit a46c55d into main Dec 4, 2023
@tbensonatl tbensonatl deleted the bugfix/fix-matvec-out-dim-sizes branch December 8, 2023 00:19
cliffburdick pushed a commit that referenced this pull request Dec 8, 2023
For matvecs, the batch dimensions for A and B should match
and the final output dimension should match dim Rank-1 from A.
Also generalize batching support so that the size of out_dims_
is based on the output rank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants