Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to schedule EmbeddingFwdOp #4023

Merged
merged 1 commit into from
Mar 6, 2025
+3 −3
Merged

Don't try to schedule EmbeddingFwdOp #4023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions csrc/scheduler/registry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ bool checkCanSchedule(Fusion* fusion, SchedulerType scheduler_type) {

FusionGuard fg(fusion);

// Fusions with `SdpaFwdOp/SdpaBwdOp` are only accepted in `ExprEval`
// These ops are are only accepted in `ExprEval`
// scheduler, all other schedulers should reject them.
if (ir_utils::hasOpsOfType<SdpaFwdOp, SdpaBwdOp>(fusion)) {
if (ir_utils::hasOpsOfType<SdpaFwdOp, SdpaBwdOp, EmbeddingFwdOp>(fusion)) {
scheduler_debug_utils::canScheduleRejectReason(
scheduler_type, "SdpaOps are not supported.");
scheduler_type, "Has unsupported ops");
return false;
}

Expand Down