This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Expose common dataset interface #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the direction! Looks like this is a work-in-progress? Looks like you removed |
|
I didn't base this commit on the latest version of master because of the parameter-sweep issue. Other than that, I feel this could be good to merge if it passes the test of your most accurate review filter :-) I didn't add |
gheinrich
force-pushed
the
dev/common-dataset-interface
branch
from
2399472 to
351f2c3
Compare
|
Rebased on tip of master branch. |
This will allow to create new types of datasets without making changes in other parts of DIGITS.
gheinrich
force-pushed
the
dev/common-dataset-interface
branch
from
351f2c3 to
bec92de
Compare
|
I think this is working. I ran into some Torch errors, but I don't think they were related. |
gheinrich
added a commit
to gheinrich/DIGITS
that referenced
this pull request
May 27, 2016
The resize mode is no longer used by the test.lua Torch wrapper. Besides this field isn't part of the common dataset interface. Using it is causing problems during multiple image inference in Torch when using generic datasets. This should have been changed in NVIDIA#723
gheinrich
added a commit
to gheinrich/DIGITS
that referenced
this pull request
May 27, 2016
The resize mode is no longer used by the test.lua Torch wrapper. Besides this field isn't part of the common dataset interface. Using it is causing problems during multiple image inference in Torch when using generic datasets. This should have been changed in NVIDIA#723
gheinrich
added a commit
to gheinrich/DIGITS
that referenced
this pull request
May 27, 2016
The common dataset interface exposes a get_mean_file() method to retrieve the mean file. Using the dataset.mean_file attribute only works for "images/generic" datasets. This should have been changed in NVIDIA#723
This was referenced May 27, 2016
gheinrich
added a commit
to gheinrich/DIGITS
that referenced
this pull request
May 27, 2016
The resize mode is no longer used by the test.lua Torch wrapper. Besides this field isn't part of the common dataset interface. Using it is causing problems during multiple image inference in Torch when using generic datasets. This should have been changed in NVIDIA#723
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
…face Expose common dataset interface
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
The resize mode is no longer used by the test.lua Torch wrapper. Besides this field isn't part of the common dataset interface. Using it is causing problems during multiple image inference in Torch when using generic datasets. This should have been changed in NVIDIA#723
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
The common dataset interface exposes a get_mean_file() method to retrieve the mean file. Using the dataset.mean_file attribute only works for "images/generic" datasets. This should have been changed in NVIDIA#723
SlipknotTN
pushed a commit
to cynnyx/DIGITS
that referenced
this pull request
Mar 30, 2017
The resize mode is no longer used by the test.lua Torch wrapper. Besides this field isn't part of the common dataset interface. Using it is causing problems during multiple image inference in Torch when using generic datasets. This should have been changed in NVIDIA#723
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to create new types of datasets without making changes in other parts of DIGITS.
Ultimately, class relationships may look like:
