Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nvImageCodec to 0.4.1 version #5576

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Upgrade nvImageCodec to 0.4.1 version #5576

wants to merge 37 commits into from

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Jul 22, 2024 •
edited
Loading

Category:

Other Performance

Description:

  • Adapt to nvImageCodec 0.4.x API

Additional information:

Affected modules and functionalities:

ImageDecoder mostly (any operator that has a mixed backend thread pool)

  • ImageDecoder

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16808221]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16808221]: BUILD FAILED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 9737476 to 820495b Compare July 22, 2024 15:29
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16811949]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16813241]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16813356]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16813388]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16814374]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16811949]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16814374]: BUILD PASSED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 820495b to 7e1910f Compare July 22, 2024 23:28
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16825232]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16825232]: BUILD PASSED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 7e1910f to 0200981 Compare July 23, 2024 08:30
@jantonguirao jantonguirao marked this pull request as draft July 23, 2024 08:31
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16836552]: BUILD STARTED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 0200981 to 3f86113 Compare July 23, 2024 08:34
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16836608]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16836608]: BUILD PASSED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 82fa82f to f156720 Compare July 23, 2024 12:35
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16842081]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16842081]: BUILD FAILED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from f156720 to 18609f9 Compare July 23, 2024 17:39
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 18609f9 to c44c269 Compare July 23, 2024 17:42
@jantonguirao jantonguirao changed the title Create a few CUDA events per thread pool thread Optimize thread pool Jul 23, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16850269]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [16850269]: BUILD PASSED

@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from c44c269 to 72f8945 Compare July 24, 2024 07:58
@jantonguirao
Use dynamic linking for tegra as well
8a31d02 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
a9197a1 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Require nvImageCodec 0.4.1
d01d513 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Temporary change
e49556a 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Remove CUDA event pool prepopulation
9108ccf 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
c327be0 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Use hw_decoder_load=0 in dali_variable_batch_size for determinism
4ae0382 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fix
6f6311f 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Remove old doc
033f4f6 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Use default hw_decoder_load again
dd6185f 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Do not use hw decoder for variable batch size tests
506399a 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Make non-contiguous alloc
07e27e5 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
5d5cca7 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
bf41d39 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Limit number of setup blocks
5ebfab4 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
e65f445 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Fixes
bf74581 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
cooperative setup
8e0e80e 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21963150]: BUILD STARTED

@jantonguirao
Add --experimental_decoder option
1925758 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
static analysis fix
e479091 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Override hw_decoder_load for nvimagecodec 0.4.x versions (workaround …
d10d283 
…for non-deterministic backend assignment)

Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao
Bump minimum version
e3067a4 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 867e42e to e3067a4 Compare December 30, 2024 16:13
@jantonguirao
Fix test.sh
d45db51 
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@jantonguirao jantonguirao force-pushed the create_events_per_thread branch from 767d30f to d45db51 Compare December 30, 2024 16:33
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21963479]: BUILD STARTED

@jantonguirao jantonguirao changed the title Improve performance of ImageDecoder (required nvImageCodec >= 0.4.0) Upgrade nvImageCodec to 0.4.1 version Dec 30, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21963479]: BUILD PASSED

@JanuszL JanuszL mentioned this pull request Jan 2, 2025
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banasraf banasraf banasraf left review comments

@awolant awolant awolant approved these changes

@klecki klecki klecki approved these changes

Assignees

@klecki klecki

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jantonguirao @dali-automaton @klecki @banasraf @awolant