Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for using conditionals in DALI #4569

Closed
wants to merge 8 commits into from

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Jan 13, 2023

Category: Other

Description:

Add the tutorial, first commit is from PR implementing the conditionals,
TODO:

  • Mention in the pipeline.rst
  • More advanced example that shows tracing through functions.
  • Mention that arguments to the pipeline are also traced?

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Krzysztof Lecki <[email protected]>

Lint

Signed-off-by: Krzysztof Lecki <[email protected]>

Move test and invoke it separately

Signed-off-by: Krzysztof Lecki <[email protected]>

Revert

Replace DataNode hash with beefed up repr for better uniqueness

Signed-off-by: Krzysztof Lecki <[email protected]>

Revert

Signed-off-by: Krzysztof Lecki <[email protected]>

Rename

Signed-off-by: Krzysztof Lecki <[email protected]>

Do not call init again

Signed-off-by: Krzysztof Lecki <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@klecki
Copy link
Contributor Author

klecki commented Jan 13, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7010389]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7010389]: BUILD FAILED

Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
Signed-off-by: Krzysztof Lecki <[email protected]>
@JanuszL JanuszL mentioned this pull request Jan 17, 2023
@klecki
Copy link
Contributor Author

klecki commented Mar 20, 2023

Tutorial and example were merged, some of this goes into blogpost, some will be a dedicated documentation.

@klecki klecki closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants