Add axes_utils.h #4548
Merged
Add axes_utils.h #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
axes_utils
branch
from
d3d57f2 to
02b8d12
Compare
|
!build |
|
CI MESSAGE: [6938122]: BUILD STARTED |
jantonguirao
force-pushed
the
axes_utils
branch
from
02b8d12 to
0ff8a2f
Compare
|
!build |
|
CI MESSAGE: [6938365]: BUILD STARTED |
|
CI MESSAGE: [6938365]: BUILD FAILED |
jantonguirao
force-pushed
the
axes_utils
branch
from
0ff8a2f to
d3aafeb
Compare
|
!build |
stiepan
approved these changes
Jan 5, 2023
|
CI MESSAGE: [6938577]: BUILD STARTED |
|
CI MESSAGE: [6938577]: BUILD FAILED |
jantonguirao
force-pushed
the
axes_utils
branch
from
d3aafeb to
d3e72aa
Compare
|
!build |
|
CI MESSAGE: [6939042]: BUILD STARTED |
|
CI MESSAGE: [6939042]: BUILD FAILED |
jantonguirao
force-pushed
the
axes_utils
branch
from
d3e72aa to
d408375
Compare
|
!build |
|
CI MESSAGE: [6939418]: BUILD STARTED |
stiepan
approved these changes
Jan 5, 2023
|
CI MESSAGE: [6939418]: BUILD FAILED |
|
CI MESSAGE: [6939418]: BUILD PASSED |
jantonguirao
force-pushed
the
axes_utils
branch
3 times, most recently
from
a34b34c to
9e0dce3
Compare
jantonguirao
commented
Jan 9, 2023
Comment on lines
-247
to
-248
| reduce_impl::CheckAxes(make_cspan(axes), ndim()); | ||
| reduce_impl::AdjustAxes(make_span(axes), ndim()); |
There was a problem hiding this comment.
Already checked at the operator level (and it's where it should be done)
jantonguirao
commented
Jan 9, 2023
| @@ -408,11 +408,8 @@ class ReduceImplGPU { | |||
| if (in_shape.sample_dim() > 64) | |||
| throw std::range_error("Reduce supports up to 64 dimensions"); | |||
| reduce_batch_ = reduce_batch; | |||
| int ndim = in_shape.sample_dim(); | |||
| CheckAxes(axes_arg, ndim); | |||
There was a problem hiding this comment.
Already checked at the operator level (and it's where it should be done)
|
!build |
|
CI MESSAGE: [6967378]: BUILD STARTED |
mzient
approved these changes
Jan 9, 2023
Signed-off-by: Joaquin Anton <[email protected]>
jantonguirao
force-pushed
the
axes_utils
branch
from
9e0dce3 to
3ae174e
Compare
|
!build |
|
CI MESSAGE: [6968361]: BUILD STARTED |
|
CI MESSAGE: [6968361]: BUILD PASSED |
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Joaquin Anton <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton [email protected]
Category:
Refactoring
Description:
Additional information:
Affected modules and functionalities:
Reduction kernels
Key points relevant for the review:
NA
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A