Code

Get embedding sizes refactor#1127

Code

Merged

karlhigley merged 11 commits intoNVIDIA-Merlin:mainNVIDIA-Merlin/NVTabular:mainfrom jperez999:get-embedding-sizes-fixjperez999/NVTabular:get-embedding-sizes-fixCopy head branch name to clipboardSep 21, 2021

+124-36

Commits

Commits on Sep 16, 2021

• almost completely working embeddings sizes

  jperez999

  committed
  2d588ac

  Copy full SHA for 2d588ac

Commits on Sep 17, 2021

• get embedding sizes now working

  jperez999

  committed
  e2f9d57

  Copy full SHA for e2f9d57

• fix merge conflicts

  jperez999

  committed
  4bac9e8

  Copy full SHA for 4bac9e8

• Merge branch 'main' into get-embedding-sizes-fix

  jperez999

  authored
  df39765

  Copy full SHA for df39765

Commits on Sep 19, 2021

• fix error in test logic

  jperez999

  committed
  b3bc739

  Copy full SHA for b3bc739

• Merge branch 'get-embedding-sizes-fix' of https://github.com/jperez999/NVTabular into get-embedding-sizes-fix

  jperez999

  committed
  cc1fe67

  Copy full SHA for cc1fe67

Commits on Sep 20, 2021

• fix bugs in tests in ops

  jperez999

  committed
  1c907f7

  Copy full SHA for 1c907f7

• Merge branch 'main' into get-embedding-sizes-fix

  jperez999

  authored
  c76f67b

  Copy full SHA for c76f67b

• joinexternal now casts all to dataset to infer and propagate schema

  jperez999

  committed
  5eb9c15

  Copy full SHA for 5eb9c15

• Merge branch 'get-embedding-sizes-fix' of https://github.com/jperez999/NVTabular into get-embedding-sizes-fix

  jperez999

  committed
  6675990

  Copy full SHA for 6675990

• remove unnecessary added param for call is checked within function

  jperez999

  committed
  69ee736

  Copy full SHA for 69ee736