Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kan 25 retrieve events data #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Kan 25 retrieve events data #2

wants to merge 2 commits into from

Conversation

joyngjr
Copy link

@joyngjr joyngjr commented Mar 31, 2024

Pull Request

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Changes

  • Queries events table and displays all values

Checklist:

  • I have tested my changes locally.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.

Additional Notes:

yongning0310
yongning0310 requested changes Jun 10, 2024
View reviewed changes
Copy link

@yongning0310 yongning0310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some conflicts in routes/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongning0310 yongning0310 yongning0310 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyngjr @yongning0310 @RubyNguyen07