Fix false positive for Question#triggered? #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 6, 2014 18:01
I'm working on enforcing mandatory questions, and I noticed that questions without explicit dependencies inside of question groups with dependencies were erroneously reporting themselves to be triggered, which prevented a user from moving on in the survey. This issue probably needs to be addressed inside `ResponseSet#progress_hash` as well.
Questions with the label display type cannot be answered, but is_answered? was returning true. Since I'm relying on is_unanswered? for enforcing mandatory questions, it makes more sense for it to return false for labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on enforcing mandatory questions, and I noticed that questions without explicit dependencies inside of question groups with dependencies were erroneously reporting themselves to be triggered, which prevented a user from moving on in the survey.
This issue probably needs to be addressed inside
ResponseSet#progress_hashas well.