Fix TaskResult IDs skipped in Task Results #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhazentia
commented
Nov 21, 2024
jhazentia
commented
- Added sleep after creating healthcheck file
- Added check and warning for task id mismatch
- Stops scheduler thread after triggering restart
- Reset next task id if needed when starting scheduler (this may not be needed if ASYNC_CALLBACK is disabled)
dboulware
reviewed
Dec 10, 2024
src/scheduler/scheduler.py
Outdated
| @@ -241,6 +251,7 @@ def _finalize_task_result(self, task_result, started, finished, status, detail): | |||
| task_result.save() | |||
|
|
|||
| with self.task_status_lock: | |||
| self.last_status = status | |||
There was a problem hiding this comment.
Don't set last_status before the check
dboulware
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.