This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
Changes to the working post branch #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Horrible Pull Request title btw |
james-logan
changed the title
|
@ScottH this should be ready to merge as well |
| @@ -21,3 +21,8 @@ module.exports.show = function (req, res) { | |||
| res.render('post/show', {post: post}); | |||
| }); | |||
| }; | |||
|
|
|||
| module.exports.parse = function (req, res, next) { | |||
| req.body.text = Post.parse(req.body.text); | |||
There was a problem hiding this comment.
Are you sure this is correct as req.body.text becomes an object here?
|
Pull the lastest changes from master and you should see a failing test |
…ongo now has a content key with an object that contains text
… submitting it to the database, and added tests for the constructor
|
@sscotth updates have been made to Post.create and passing tests were added |
|
|
||
| Post.validate = function (post) { | ||
| var postArray = post.trim().split(' '); | ||
| if (postArray[0] === ''){ |
There was a problem hiding this comment.
Can you use different variable names here.
Try:
var words = post.trim().split(' ');
var firstWord = words[0];
var secondWord = words[0];
|
I think you should consider making validation your middleware and not mangling the post text into an array. Simply validate and pass to Run your parse function during the Let me know if you are unsure what I mean. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.