Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

adding code for autocomplete handler in main.js. Todo: tests #31

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

johnwquarles
Copy link
Member

Frontend code to be added to whatever page winds up having the text input field. Todo: write tests.

@@ -0,0 +1,89 @@
/*global $:false */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sscotth sscotth force-pushed the master branch 2 times, most recently from 393b62c to c524616 Compare August 20, 2015 20:25
@johnwquarles
Copy link
Member Author

@sscotth Code has been rewritten for Horsey.

@johnwquarles
Copy link
Member Author

@sscotth marge plz plz

@@ -0,0 +1,74 @@
/*eslint-env jquery */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add jquery to the .eslintrc file and not use a comment

@johnwquarles
Copy link
Member Author

@sscotth Ready for review. I don't know why the Travis info isn't showing up; it's passing, please check here to see:

https://travis-ci.org/NSS-Cohort-9/minitwit/builds/76700673

@johnwquarles
Copy link
Member Author

Travis still AWOL, so here's the build:

https://travis-ci.org/NSS-Cohort-9/minitwit/builds/76706720

@johnwquarles
Copy link
Member Author

@sscotth marge plz

@sscotth
Copy link
Contributor

sscotth commented Aug 26, 2015

Merged @calebgregory's #28, can you pull master and make sure everything is working?

@johnwquarles
Copy link
Member Author

@sscotth merge plz marge plz minaj plz

@johnwquarles
Copy link
Member Author

@sscotth JUSTDOIT

@sscotth
Copy link
Contributor

sscotth commented Aug 27, 2015

Getting there ;) I'll make some comments below, but I'd like to see tab completion. You can do this in a separate pull request though

@@ -1,2 +1,2 @@
link(rel='stylesheet', href='/styles/main.css')

link(rel='stylesheet', href='/lib/horsey/dist/horsey.min.css')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always import the styles/JavaScripts from third parties before your own. But in this case, it is even more preferred to use a sass import instead of directly linking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a way to link to a Sass-compiled CSS file without directly linking to it? Is that something server-side?

http://sass-lang.com/documentation/file.SASS_REFERENCE.html#custom_importers ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants