-
Notifications
You must be signed in to change notification settings - Fork 18
adding code for autocomplete handler in main.js. Todo: tests #31
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,89 @@ | |||
/*global $:false */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply add jquery to the eslintrc file
http://eslint.org/docs/user-guide/configuring.html#specifying-environments
393b62c
to
c524616
Compare
…ab completion, include user pic with suggestion
@sscotth Code has been rewritten for Horsey. |
@sscotth plz |
@@ -0,0 +1,74 @@ | |||
/*eslint-env jquery */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add jquery to the .eslintrc
file and not use a comment
…ed, gitignored, added bower install to travis.yml
…al or global form of 'use strict'
…al or global form of 'use strict'
…inked autocomplete javascript in javascripts partial
@sscotth Ready for review. I don't know why the Travis info isn't showing up; it's passing, please check here to see: |
Travis still AWOL, so here's the build: |
Merged @calebgregory's #28, can you pull master and make sure everything is working? |
… it on the frontend, should work now
… need to not pass event into the handler functions, as that broke the code too. So gotta figure out how to get this to pass the linter
Getting there ;) I'll make some comments below, but I'd like to see tab completion. You can do this in a separate pull request though |
@@ -1,2 +1,2 @@ | |||
link(rel='stylesheet', href='/styles/main.css') | |||
|
|||
link(rel='stylesheet', href='/lib/horsey/dist/horsey.min.css') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always import the styles/JavaScripts from third parties before your own. But in this case, it is even more preferred to use a sass import instead of directly linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a way to link to a Sass-compiled CSS file without directly linking to it? Is that something server-side?
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#custom_importers ?
Frontend code to be added to whatever page winds up having the text input field. Todo: write tests.