Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added iced pin check #372

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Added iced pin check #372

merged 5 commits into from
Apr 29, 2024

Conversation

vshekar
Copy link
Collaborator

@vshekar vshekar commented Apr 6, 2024

Sometimes after mount, the pin is not detected on the gonio because there is a buildup of ice between the pin and gonio
This function checks for that error, and if it is detected will check for the pin every second for max_wait_time seconds.
If after that time it still does not detect the sample it will throw an error

@vshekar vshekar requested a review from JunAishima April 6, 2024 03:24
embl_robot.py Outdated Show resolved Hide resolved
embl_robot.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this includes a major reformatting of code - can you separate that from the actual change?

@vshekar
Copy link
Collaborator Author

vshekar commented Apr 16, 2024

Undid the formatting, should be good now

embl_robot.py Outdated Show resolved Hide resolved
@JunAishima JunAishima self-requested a review April 26, 2024 13:45
@vshekar vshekar merged commit 3a53fbf into NSLS-II:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants