-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Targeting cabability for agent objectives #52
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Does this PR share commits with #49? |
OK, looks like it's only 4 commits ahead of the PR #49 branch: |
48aad50
to
2a91cce
Compare
932dd12
to
cc0e885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversion of the DOFs and objectives to Dataclasses looks great! I spotted a few non-critical issues which would be nice to address before merging.
Targeting cabability for agent objectives
This lets you optimize for a specific value of an objective, instead of just being able to minimize/maximize it. This is useful for e.g. getting a particular beam spot size on demand, or for "color on command" for quantum dot experiments.