Improve energy model error #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfitzgerald
requested changes
Nov 10, 2023
| @@ -152,6 +144,8 @@ impl TryFrom<(Arc<SpeedGradeModelService>, &serde_json::Value)> for SpeedGradeMo | |||
| ) -> Result<Self, Self::Error> { | |||
| let (service, conf) = input; | |||
|
|
|||
| let model_names: Vec<&String> = service.energy_model_library.keys().collect(); | |||
There was a problem hiding this comment.
if we move line 147 to line 181, we only build this vector if there is an error, instead of building it each time we process a query
There was a problem hiding this comment.
yep yep, that's a good point, change forthcoming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error for the speed grade model when the energy model provided under the
model_nameparameter cannot be found in the library. When providing the key"model_name": "flying_car"for the default OSM energy config produces the error:closes #23