Fix PyO3 0.21 deprecation warnings #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
rasterio
andgdal
imports at the top of the OSM example notebook to fail faster (rather than waiting for grade data to download on slow PyCon wifi)https://pyo3.rs/v0.21.2/migration#from-020-to-021
According to the above link, there are some API changes for 0.21 to remove GIL markers. This means changing the pymodule def:
As well as classmethod defs (though this one could be a staticmethod and it works just fine, since we don't use the pyclass):
Also in the OSM example I had issues with failing imports during grade data building, so I added a try/except at the top to catch those errors sooner.
Fixes #167