Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distance to state model in SpeedTraversalModel and other small fixes #194

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

nreinicke
Copy link
Collaborator

Some small fixes uncovered during a recent debugging session:

  • speed traversal model didn't add distance during the state estimation
  • adds a test to priority queue to make sure it works properly with reverse costs
  • corrects the expected keys for energy time and distance units
  • for the CLI app, sets --chunksize to only a long argument since the short argument -c conflicts with --config-file

@nreinicke nreinicke requested a review from robfitzgerald April 26, 2024 21:31
@robfitzgerald
Copy link
Collaborator

@nreinicke this looks fine but there is a merge conflict to address

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@nreinicke nreinicke merged commit 0a07182 into main Apr 30, 2024
5 checks passed
@nreinicke nreinicke deleted the ndr/small-fixes branch April 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants