update example notebook; bugfixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool, thanks for superseding. did you look into whether grade issues were a problem here too, or is that just elsewhere? |
|
I did double check grade in this case and everything looked okay, (we download the grade as decimal in this case) |
robfitzgerald
approved these changes
Mar 19, 2024
| @@ -73,26 +73,26 @@ def generate_compass_dataset( | |||
| agg = agg if agg is not None else np.mean | |||
|
|
|||
| # pre-process the graph | |||
| log.info("processing graph topology and speeds") | |||
| print("processing graph topology and speeds") | |||
There was a problem hiding this comment.
but what about logging? maybe we just need to be sure to set up logging.basicConfig correctly in the python library?
There was a problem hiding this comment.
yeah there's probably the right way to do it that I didn't have the time to investigate; the motivation was that it was not logging to the jupyter notebook and so it was hard to tell what was happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #131 by merging that notebook with the notebook on the main branch.
Also includes a few fixes found along the way: