Rjf/unit create by ref #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreinicke
approved these changes
Mar 15, 2024
|
Didn't run a test to see, I kinda just whipped this up while on a call with tech support for the VPN problems I've been having, and assumed it would help things. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR makes it so any units functions take references to their arguments instead of pass-by-value semantics, which should reduce a bunch of unnecessary allocations in our core floating point operations.
still, looking at the bottom of the call stack at the code in routee-compass/src/model/unit/builders.rs, i'm not convinced that we have made these operations as fast as they can be. some additional work could be done to ensure we're not allocating temp objects and perhaps bypassing a conversion to the base units too.