Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ambient TI as a function of wind direction and wind speed #713

Closed
Bartdoekemeijer opened this issue Sep 19, 2023 · 7 comments
Assignees
Labels
enhancement An improvement of an existing feature floris.simulation
Milestone

Comments

@Bartdoekemeijer
Copy link
Collaborator

Feature request: turbulence_intensity as a function of wind direction and wind speed

The industry typically evaluates the annual energy production of a site by using a wind rose of the site, specifying the frequency of each combination of wind direction and wind speed. Additionally, we are often provided one ambient turbulence intensity value for each of those wind direction/speed bins. Alternatively, we may be given a wind-speed vs. turbulence intensity curve, showing that turbulence is high at low wind speeds, and much lower at high wind speeds. FLORIS only allows us to insert one turbulence value for the entire wind rose. With a relatively small change, I think we could update this and provide this very useful functionality.

Proposed solution

Allow users to insert two-dimensional table for turbulence_intensity, which matches the dimensions (n_wind_directions, n_wind_speeds).

Alternatives considered

One can also simply apply a for-loop over each wind direction and wind speed and apply the relevant TI for each bin, but that completely beats the purpose of the refactorizations of FLORIS v3.

Additional context

I have written up a preliminary solution that I'll post over in the PR section.

@maapasan
Copy link

Hello @Bartdoekemeijer

I agree with you, turbulence intensity is a significant characteristic and it is related with the wake simulation (basis of FLORIS).
I sent an issue that I think that is totally related with your suggestion. #666

Kind regards from CENER :)

@Bartdoekemeijer
Copy link
Collaborator Author

Ah of course, @maapasan! Thanks for highlighting that! I'm becoming a bit lazy and not searching the existing Issues like I should have! Will leave my Issue here but will link yours too in my PR.

@rafmudaf rafmudaf added this to the v4.0 milestone Nov 8, 2023
@rafmudaf rafmudaf self-assigned this Nov 8, 2023
@rafmudaf rafmudaf added enhancement An improvement of an existing feature floris.simulation labels Nov 8, 2023
@rafmudaf rafmudaf modified the milestones: v4.0, v4.1 Nov 29, 2023
@christiannvaughn christiannvaughn moved this to Future Steps in FLORIS v4 Dec 5, 2023
@paulf81
Copy link
Collaborator

paulf81 commented Jan 12, 2024

Plan to address this is in #775

@paulf81 paulf81 moved this from Future Steps to In Progress in FLORIS v4 Jan 12, 2024
@paulf81 paulf81 assigned paulf81 and unassigned rafmudaf Jan 12, 2024
@paulf81 paulf81 modified the milestones: v4.1, v4.0 Jan 16, 2024
@paulf81
Copy link
Collaborator

paulf81 commented Jan 17, 2024

now connecting to Issue #778

@paulf81
Copy link
Collaborator

paulf81 commented Jan 19, 2024

@Bartdoekemeijer , if you have a chance, have a look at #782 which I think addresses this issue

@paulf81
Copy link
Collaborator

paulf81 commented Jan 25, 2024

@Bartdoekemeijer #782 is now in review if you want to have a look to make sure this does what you wanted

@paulf81
Copy link
Collaborator

paulf81 commented Feb 3, 2024

This is included in v4 via #782

@paulf81 paulf81 closed this as completed Feb 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in FLORIS v4 Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature floris.simulation
Projects
Status: Done
Development

No branches or pull requests

4 participants