NSRDB/REDE - 8678 - Dataset Deprecation + Removal #374
+3
−620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PjEdwards
reviewed
Feb 3, 2025
There was a problem hiding this comment.
I realize this is still in draft, so apologies if my comments are duplicative of what's in https://github.nrel.gov/IDEA/vadr/issues/8678#issuecomment-65767 I believe the remaining work here is to restore vietnam and philippines docs with a notice that they've been replaced, and add the deprecation notice for march to the other 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes solar data documentation for the Philippines and Vietnam and marks all NSRDB 3.x variants as deprecated in their respective documentation pages (placing notice that they will disappear at end of March 2025 in docs)
resolves https://github.nrel.gov/IDEA/vadr/issues/8678