Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume postprocessing #310

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Resume postprocessing #310

wants to merge 7 commits into from

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Oct 14, 2022

Fixes # .

Pull Request Description

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@github-actions
Copy link

github-actions bot commented Oct 14, 2022

File Coverage
All files 78%
base.py 81%
eagle.py 74%
exc.py 57%
localdocker.py 27%
postprocessing.py 83%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 24%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 36%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against ebfc2b8

@afontani
Copy link
Collaborator

Not a high priority, but might be good to merge with a couple features:

  1. flexibility to specify scheduler memory
  2. resuming post-processing from a previous partial failed run

@afontani
Copy link
Collaborator

afontani commented Nov 1, 2022

Holding off on this feature until there is a need again for resuming post-processing. If another use case shows up, then clean this up into an official feature.

@afontani
Copy link
Collaborator

afontani commented Apr 5, 2023

@rajeee : wasn't this addressed or was it just the array jobs that will run the ones that did not complete?

@afontani
Copy link
Collaborator

afontani commented Apr 5, 2023

@rajeee confirmed the Jobs being resumed feature is complete but not the post-processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants