Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versioneer in favor of setuptools_scm #59

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Remove versioneer in favor of setuptools_scm #59

merged 10 commits into from
Aug 26, 2024

Conversation

cdeline
Copy link
Contributor

@cdeline cdeline commented Aug 23, 2024

No description provided.

@cdeline cdeline requested a review from shirubana August 23, 2024 22:26
@cdeline
Copy link
Contributor Author

cdeline commented Aug 23, 2024

I'll squash some deprecationWarnings while I'm in here:

  • bifacialvf\bifacialvf.py:94 DeprecationWarning: invalid escape sequence '\E'
  • bifacialvf/tests/test_bifacialvf.py::31: FutureWarning: The behavior of 'isin' with dtype=datetime64[ns, UTC-05:00] and castable values (e.g. strings) is deprecated. In a future version, these will not be considered matching by isin. Explicitly cast to the appropriate dtype before calling isin instead. assert np.allclose(myTMY3[myTMY3.index.isin(...
  • bifacialvf/tests/test_bifacialvf.py::test_1axis_endtoend sun.py:726, 729: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method. sunup['minutedelta'].mask(sunrisemask,np.floor((60-(sunup['sunrise'].dt.minute))/2),inplace=True)
  • bifacialvf\bifacialvf.py:327: FutureWarning: A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method. trackingdata.surface_tilt.fillna(stowingangle, inplace=True)

@mikofski
Copy link
Contributor

mikofski commented Aug 26, 2024

Hi Chris, why leave pandas out of the updates? I think v0.25 is very old. Latest version is pandas-2.2. I think best practice is NEP-29 which puts you closer to pandas-1.4

@cdeline
Copy link
Contributor Author

cdeline commented Aug 26, 2024

@mikofski - great point. By removing python 3.7 support we could bump up pandas to 2.0.3 and numpy to 1.24.4 which I believe is the limit for py 3.8 support.

@cdeline cdeline merged commit 8e62a7f into main Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants