Transmissivity as a function of incident angle #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new functionality to allow specification of transmissivity as a function of ray incident angle. The functionality largely mimics the existing reflectivity table. This resolves #29.
In the process of implementing, it was noted that the current reflectivity input table requests angles in units of "mrad," but the code treats the input in units of "rad." The code was fixed to anticipate angles entered in units of "mrad" for both the existing reflectivity table and for the new transmissivity table. The custom dialog was previously dedicated to the reflectivity input, but has now been generalized to manage either reflectivity or transmissivity depending on constructor argument.
This PR includes changes to the file read/write functionality. Full backwards compatibility is intended so that SolTrace can continue to read in files created with prior versions without issue. New files written will include additional information on the transmissivity table and settings.