Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 release candidate defaults changes #1971

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 10, 2024

Pull Request Template

Description

Fixes #1966

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added this to the SAM Fall 2024 Release milestone Dec 10, 2024
@brtietz brtietz requested a review from sjanzou December 10, 2024 23:48
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the api and defaults in one pass - the 2024.12.12.ssc.279 main_add.h update was merged into this branch for completeness!

@brtietz brtietz merged commit 51d0db4 into develop Dec 11, 2024
8 checks passed
@brtietz brtietz deleted the 2024_release_candidate_defaults_changes branch December 13, 2024 19:21
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent hybrids defaults
4 participants