Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update case comparison macro #1967

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Update case comparison macro #1967

merged 1 commit into from
Dec 11, 2024

Conversation

mjprilliman
Copy link
Collaborator

Description

-Exit from macro for Third Party - Host, as there are no financials
-Fix after-tax cash flow variable for Host Developer configs
-Fix typo in error message for non-supported financial models

@mjprilliman mjprilliman added the dev bug Internal bug that should not be included in release notes label Dec 10, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
@mjprilliman mjprilliman self-assigned this Dec 10, 2024
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

For future consideration: For battery cases, it might be useful to show battery roundtrip efficiency. Note that capacity factor for Standalone Battery configs is reported as infinity (untitled (2) case in this screenshot):

image

@mjprilliman mjprilliman merged commit c04c27e into develop Dec 11, 2024
8 checks passed
@mjprilliman mjprilliman deleted the comparison-marco-fixes branch December 11, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants