Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version upgrade for CSP models. #1962

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

taylorbrown75
Copy link
Collaborator

Pull Request Template

Description

Update version upgrade to account for CSP variable additions/name changes:

  • Account for variable (h_tank) name change in trough CSP and IPH models.
  • Fix bug loading tes_type.
  • Define startup and shutdown temperature default values when loading old SAM files.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@taylorbrown75 taylorbrown75 added the csp concentrating solar power label Dec 8, 2024
@taylorbrown75 taylorbrown75 added this to the SAM Fall 2024 Release milestone Dec 8, 2024
@taylorbrown75 taylorbrown75 self-assigned this Dec 8, 2024
Copy link
Collaborator

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taylorbrown75 taylorbrown75 merged commit aa89930 into develop Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csp concentrating solar power
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants