Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart, macro, and sample file upgrades #1948

Merged
merged 17 commits into from
Dec 10, 2024

Conversation

janinefreeman
Copy link
Collaborator

Updates the mini grid macro file to the latest SAM version (note to reviewers - please test that quickstart function), the PV subarray layout optimization macro for new bounds on the GCR input, and small updates to the sample scripts.

@janinefreeman janinefreeman added this to the SAM Fall 2024 Release milestone Dec 5, 2024
@dguittet
Copy link
Collaborator

dguittet commented Dec 6, 2024

Works-- really nice example and plots!

I am getting this old SAM version notification though
image

@dguittet
Copy link
Collaborator

dguittet commented Dec 6, 2024

The Subarray macro has tables that use GCR=1 that need to be updated with the new max value of 0.99:
image

Also, why do some rows have commas and others don't?

It would be faster to switch the analysis period to 1, temporarily.

Lastly, if tilt=latitude is checked, that seems to fix the tilt angle throughout the optimization, so it should be temporarily unchecked

@janinefreeman
Copy link
Collaborator Author

Hmm, that's super weird that you're getting the old file version upgrade notice for the mini-grid example- it shows as updated on my computer. I just tried re-saving it and pushing it, can you see if it works now? If not, could this be a Mac vs Windows issue?

@janinefreeman
Copy link
Collaborator Author

Good thought about making analysis period 1 temporarily, that's MUCH faster. I didn't write the macro originally, just updating it to work with the latest version, so not sure why the number formatting is different in different rows... But the table shows the correct max GCR for me (everything in the table is keyed off of the max GCR input). Could it be that your local build didn't sync correctly with this one?
temporary

@dguittet
Copy link
Collaborator

dguittet commented Dec 9, 2024

I'm not getting the version upgrade notice anymore!

But I'm still getting the extended table for the array macro, even after manually copying over the new code. But the table looks the same in the 2023.12.17 SAM, so might be a Mac thing...

@dguittet
Copy link
Collaborator

dguittet commented Dec 9, 2024

I tested it on Windows and it's the same. What I did was run the array macro on the file created with the Quick Start for Puerto Rico.

Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini grid wizard works on Windows

@janinefreeman janinefreeman merged commit 45b5ebb into develop Dec 10, 2024
8 checks passed
@janinefreeman janinefreeman deleted the quickstartAndSampleFileUpgrades branch December 10, 2024 02:56
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants