Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report template updates #1947

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Report template updates #1947

merged 4 commits into from
Dec 6, 2024

Conversation

mjprilliman
Copy link
Collaborator

@mjprilliman mjprilliman commented Dec 5, 2024

Description

-Update monthly energy print checking for basic report (all technologies except IPH ones, remove retired technologies from check)
-Updates to marine energy report to allow it to work for wave and tidal, SO and LCOEFCR, + different converter and resource definition options
-Minor update to marine variable name for tidal turbine design feature

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Dec 5, 2024
@mjprilliman mjprilliman self-assigned this Dec 5, 2024
@mjprilliman
Copy link
Collaborator Author

@cpaulgilman I'll do some more testing on the RC, but for now these changes seemed to work well in the editor and in generating the pdfs. Most of my testing was for marine as that was the one that needed the most updates. We also have some patch issues for continued report improvements.

@mjprilliman mjprilliman merged commit c8fb178 into develop Dec 6, 2024
4 of 8 checks passed
@mjprilliman mjprilliman deleted the report-template-updates branch December 6, 2024 20:50
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants