-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version upgrade fixes #1932
Version upgrade fixes #1932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update m3 label for piston cylinder TES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing the MSLF system design bug! I set the aux and bop calculated variables (SC_CALC_bop, SC_CALC_aux) to the failure integer if the cmod fails.
I also fixed a version upgrade error related to the new TES model.
This is being used both when a variable name changes and when a variable's value changes, so showing "Changed 'variable_name' to: [variable value]" is confusing when the variable name changed but the variable value did not change. Showing "variable_name = [variable_value]" is clear in either case.
@taylorbrown75 Could you test my latest changes to make sure they work with any special cases of old IPH/CSP files you might have? |
@cpaulgilman Thank you for making those changes, the version upgrade is much clearer now. I tested old files and everything works! |
Description
-Cleanup to version upgrade based on release testing
-UI labels on PV module page to make update to library variable names less confusing on upgrade
-Cleanup of MSLF MIMO to avoid equation error
-Updating of generic system variable names, config name
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.