Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade fixes #1932

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Version upgrade fixes #1932

merged 12 commits into from
Dec 6, 2024

Conversation

mjprilliman
Copy link
Collaborator

Description

-Cleanup to version upgrade based on release testing
-UI labels on PV module page to make update to library variable names less confusing on upgrade
-Cleanup of MSLF MIMO to avoid equation error
-Updating of generic system variable names, config name

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the dev bug Internal bug that should not be included in release notes label Dec 2, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Dec 2, 2024
@mjprilliman mjprilliman self-assigned this Dec 2, 2024
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions failing because default configurations do not run... e.g. Standalone Battery:
image

Updated all configurations with issues and reran defaults.
The version upgrade seems to be working!

Copy link
Collaborator

@taylorbrown75 taylorbrown75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing the MSLF system design bug! I set the aux and bop calculated variables (SC_CALC_bop, SC_CALC_aux) to the failure integer if the cmod fails.

I also fixed a version upgrade error related to the new TES model.

@cpaulgilman
Copy link
Collaborator

I'm working to make the message clearer so that users can see what the variable name change is. This may be useful for PySAM and SDK users. I'll add a commit when that's ready

Right now, the messages make it look like the variable's value changed:

image

This is being used both when a variable name changes and when a variable's value changes, so showing "Changed 'variable_name' to: [variable value]" is confusing when the variable name changed but the variable value did not change. Showing "variable_name = [variable_value]" is clear in either case.
@cpaulgilman
Copy link
Collaborator

@taylorbrown75 Could you test my latest changes to make sure they work with any special cases of old IPH/CSP files you might have?

@taylorbrown75
Copy link
Collaborator

@taylorbrown75 Could you test my latest changes to make sure they work with any special cases of old IPH/CSP files you might have?

@cpaulgilman Thank you for making those changes, the version upgrade is much clearer now. I tested old files and everything works!

@mjprilliman mjprilliman merged commit d38028d into develop Dec 6, 2024
2 of 8 checks passed
@mjprilliman mjprilliman deleted the version-upgrade-fixes branch December 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants