Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net billing updates for credit expiry and same-month usage #1835

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

berg-michael
Copy link
Contributor

@berg-michael berg-michael commented Aug 8, 2024

Description

Add UI items and default values for changes to Net Billing re: SSC Pull 1200.

I'm not familiar with the SAM project as I have only used the detailed residential PV modeling functionality. So, it's not clear to me if there is a way to determine all models that require an update to the default settings for this change. I only updated the defaults file for the Flat Plate PV Residential Model. I have also updated the relevant UI files for Utility Rate. As far as I can tell, that is sufficient to update the UI across all models, but again, I've only updated the component of SAM I have any familiarity with.

Fixes # SSC Pull 1200

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

  • This change requires a documentation update

  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

berg-michael and others added 3 commits August 7, 2024 17:55
…of true-up period, (b) application of credits to current month before rollover
…expiry at end of true-up month and no application of newly generated credits to bill before rollover
@brtietz brtietz changed the base branch from patch to develop August 23, 2024 21:36
@brtietz brtietz added this to the SAM Fall 2024 Release milestone Aug 23, 2024
@brtietz brtietz added enhancement utility rate requires help revision Requires a Help revision before releasing public version labels Aug 23, 2024
@brtietz brtietz merged commit 19b10ba into NREL:develop Aug 25, 2024
2 checks passed
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 22, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release enhancement utility rate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants