Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help updates for SAM 2023.12.17 r1 #1725

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Help updates for SAM 2023.12.17 r1 #1725

merged 2 commits into from
Mar 3, 2024

Conversation

cpaulgilman
Copy link
Collaborator

Clean up window reference topics.

Detailed PV time series results, also note lat/long/elev/tz pass through from weather file

Fix PV land area and GCR descriptions.

Revise Solar Resource topic

Electric Load subhourly weather file available via solar resource Advanced Donwload option.

Clean up window reference topics.

Detailed PV time series results, also note lat/long/elev/tz pass through from weather file

Fix PV land area and GCR descriptions.

Revise Solar Resource topic

Electric Load subhourly weather file available via solar resource Advanced Donwload option.
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Mar 1, 2024
@cpaulgilman cpaulgilman requested review from brtietz and sjanzou March 1, 2024 19:30
@cpaulgilman cpaulgilman self-assigned this Mar 1, 2024
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I have a few nitpicks and found one typo, but still happy to approve.

<p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Ground coverage ratio (GCR)</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">The ratio of the photovoltaic array area to the total ground area. For an array configured in rows of modules, the GCR is the length of the side of one row divided by the distance between the bottom of one row and the bottom of its neighboring row. An array with a low ground coverage ratio (closer to zero) has rows spaced further apart than an array with a high ground coverage ratio (closer to 1).</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">The ratio of the photovoltaic array area to the ground area occupied by the array. For an array configured in rows of modules, the GCR is the length of the side of one row divided by the distance between the bottom of one row and the bottom of its neighboring row. Increasing the GCR dereases the spacing between rows.</span></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "decreases"

Is it worth mentioning that tilt doesn't affect GRC? I've gotten that question twice in the last few weeks.

<p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Land area per system capacity</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWe</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity.</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWac</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity. Typical values range between 5 and 10 acres/MWac.</span></p>
Copy link
Collaborator

@brtietz brtietz Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might recommend knocking the lower limit down to 4. The latest report from the reV team has 4.3 acres/MWac (assuming an ILR of 1.34) https://www.nrel.gov/docs/fy24osti/87843.pdf (pg 7)

<p class="p_VariableName" style="page-break-inside: avoid; page-break-after: avoid;"><span class="f_VariableName">Land area per system capacity</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWe</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity.</span></p>
<p class="p_VariableDescription"><span class="f_VariableDescription">When you choose </span><span class="f_CHInterfaceElement">Enter area per capacity in acres/MWac</span><span class="f_VariableDescription">, type the land use estimate in acres per AC megawatt of system capacity. Typical values range between 5 and 10 acres/MWac.</span></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change detailed PV based on my comment above, this also needs to change.

Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for patch 1 and release candidate.
A few comments from Brian that we can update after testing release candidate.

@sjanzou sjanzou merged commit 87aa262 into patch Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants