Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DC loss factor checks to PV, PV + battery report template #1690

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

mjprilliman
Copy link
Collaborator

Pull Request Template

Description

-Add line for DC constant curtailment/availability loss factor
-Add checks for DC hourly/period losses in table row
-Updated for PV, PV + battery templates

Fixes #1588

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added the pv pvsam1, pvwatts, hcpv label Feb 5, 2024
@mjprilliman mjprilliman added this to the 2023 Release Patch 1 milestone Feb 5, 2024
@mjprilliman mjprilliman self-assigned this Feb 5, 2024
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I'm still seeing degradation reported as "none" when the input is 0.5/yr:

image

image

  1. Description "DC Availability/Curtailment" is too long. Consider using "DC avail./curtail."

  2. Unrelated to losses, inverter name shows as "<null>":

image

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for report generator. Thanks for fixing.

There is a problem with PV-battery availability losses that I will create a separate issue for.

@mjprilliman mjprilliman merged commit cda0828 into patch Feb 27, 2024
4 checks passed
@mjprilliman mjprilliman deleted the dc-degradation-pv-report-template branch February 27, 2024 17:36
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release pv pvsam1, pvwatts, hcpv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DC degradation loss factor to report template
2 participants